feat(upgrade): update all tests and examples to work with 2015-11-06 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elnaz
force-pushed
the
update-for-new-version
branch
2 times, most recently
from
ff027ed to
39187f5
Compare
elnaz
changed the title
There was a problem hiding this comment.
I don't think you use example_address elsewhere so you can delete it's creation
There was a problem hiding this comment.
good catch, I ended up reusing it as the check.to_address since the data param was using example_address.name for dynamic html.
|
LGTM |
elnaz
force-pushed
the
update-for-new-version
branch
from
39187f5 to
0b441d1
Compare
|
LGTM |
elnaz
added a commit
that referenced
this pull request
Nov 9, 2015
feat(upgrade): update all tests and examples to work with 2015-11-06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.