Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack notification #88

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Add slack notification #88

merged 4 commits into from
Feb 15, 2022

Conversation

sudoku-lord
Copy link
Contributor

@sudoku-lord sudoku-lord commented Feb 11, 2022

Description

Added an action which runs all tests with an alert system. I set it to run twice every 24 hours, since Lob OpenAPI's monitoring system already runs every 30 minutes. We can figure out timings for both in the future.

Story

JIRA-657

Verify

  • Code runs without errors
  • Tests pass with 100% coverage

Screen Shot 2022-02-10 at 4 21 17 PM

Copy link
Contributor

@BennyKitchell BennyKitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mwj8410 mwj8410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. A few notes, but nothing that "needs" to be changed

actions/monitoring/slack_alerts.js Show resolved Hide resolved
actions/monitoring/slack_alerts.js Outdated Show resolved Hide resolved
@sudoku-lord sudoku-lord merged commit efad2ed into main Feb 15, 2022
@mwj8410 mwj8410 deleted the add_slack_notification branch March 24, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants