-
Notifications
You must be signed in to change notification settings - Fork 19
refactor: upgrade to vuepress 2 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for inspiring-euclid-d918c8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ignore looking at netlify, I can control this via a |
@@ -84,9 +84,6 @@ The preheader region appears before the header. It shows the sitewide search if | |||
- Constrained content and full width background: the content is constrained to the width of the page, while the background is full width | |||
- Constrained content and background: both the background and content are constrained and centered | |||
|
|||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image does not exist so I removed this line as it was causing the build to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAAAAANTASTIC!
Thanks so much for all this work @millnut
Thanks to Big Blue Door for sponsoring my time to work on this.
One issue we have is on large screens, the search bar is not visible between 1200px and 1350px, but let's get this deployed first and we can create a follow up issue for that (unless you want to fix it before we deploy). |
Yep let me take a look at that before merging, I'll update here once I've taken a look |
Hi @markconroy I've taken a look at this and the best way is going to be refactoring the navbar items to dropdowns, I've refactored the navbar items into groups with enough space for us to create a |
Another approach would be to never have a desktop navigation, and always use the mobile/hamburger approach no matter how wide the screen is. What you have done with the dropdown menus looks great. Let's try get this merged at Merge Tuesday tomorrow. |
What does this change?
.nvmrc
to let netlify know which Node version we require