Skip to content

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Jul 30, 2025

Motivation

This Pr implements the capability to handle LambdaURL invocations of type StreamResponse See here for more info

Changes

  • AWS::Lambda::Url accepts the InvokeMode parameter to create a LambdaUrl
  • UrlRouter can handle results with streaming separator
  • UrlRouter can handle results with simple strings

Testing

  • New AWS validated test

Copy link

github-actions bot commented Jul 30, 2025

Test Results - Preflight, Unit

21 984 tests  ±0   20 250 ✅ ±0   7m 4s ⏱️ +41s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9c367e6. ± Comparison against base commit f5d850d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 30, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9c367e6. ± Comparison against base commit f5d850d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 30, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 50m 32s ⏱️
3 372 tests 3 069 ✅ 303 💤 0 ❌
3 378 runs  3 069 ✅ 309 💤 0 ❌

Results for commit 9c367e6.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Jul 30, 2025

Coverage Status

coverage: 78.656% (+27.3%) from 51.395%
when pulling f4c884d on cp/lambda/fix/url-response-strea
into 476e7f3 on main.

Copy link

github-actions bot commented Jul 30, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 19m 32s ⏱️ - 25m 48s
3 348 tests  - 1 238  3 041 ✅  - 1 135  307 💤  - 103  0 ❌ ±0 
3 350 runs   - 1 238  3 041 ✅  - 1 135  309 💤  - 103  0 ❌ ±0 

Results for commit 9c367e6. ± Comparison against base commit f5d850d.

This pull request removes 1239 and adds 1 tests. Note that renamed tests count towards both.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
tests.aws.services.lambda_.test_lambda.TestLambdaURL ‑ test_function_url_with_response_streaming

♻️ This comment has been updated with latest results.

@pinzon pinzon added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jul 30, 2025
@pinzon pinzon added this to the 4.8 milestone Jul 30, 2025
@localstack-bot
Copy link
Contributor

Currently, only patch changes are allowed on main. Your PR labels (semver: minor) indicate that it cannot be merged into the main at this time.

@pinzon pinzon marked this pull request as ready for review July 30, 2025 21:45
@pinzon pinzon modified the milestones: 4.8, Playground Jul 31, 2025
@pinzon pinzon force-pushed the cp/lambda/fix/url-response-strea branch from f4c884d to 9c367e6 Compare August 1, 2025 15:23
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!
So the streaming payload is the metadata split by 8 \0 bytes? Interesting, really nice work!

@pinzon pinzon merged commit 3cfb711 into main Aug 6, 2025
40 checks passed
@pinzon pinzon deleted the cp/lambda/fix/url-response-strea branch August 6, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants