Re-enabling ruff rule E721 #12968
Merged
Re-enabling ruff rule E721 #12968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giograno
added
the
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 31s ⏱️ Results for commit e311256. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 22s ⏱️ Results for commit e311256. |
giograno
requested review from
simonrw,
pinzon,
dominikschubert,
thrau,
alexrashed,
silv-io,
k-a-il,
bentsku and
sannya-singal
as code owners
giograno
removed request for
simonrw,
dominikschubert,
thrau,
pinzon,
sannya-singal and
bentsku
alexrashed
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on our efforts for a better linting (e.g., #12953 and #5018), this PR re-enables the rule E721 and adjusts the code to be compliant.