CFNV2: Implement Fn::Length for language extensions

[simonrw]

Motivation

We need to support the language extensions transform to match parity with the V1 provider. We start by implementing the Fn::Length transform to demonstrate general integration with the v1 implementation. We will implement Fn::ForEach in a follow up as this is a more complex change.

Changes

• Separate local and global transforms in the ChangeSetModelTransformer.transform method
• TEMPORARILY repurpose resolve_refs_recursively to enable the feature, with the knowledge that the requirements for transforms are much lower, and we can potentially re-purpose the ChangeSetVisitor or similar to re-write this usage after the new provider is released
  • This allows us to repurpose the v1 implementation of the language extensions macro which we know is in parity with AWS and has been validated by customers
• Unskip the Fn::Length test

[github-actions]

Test Results - Preflight, Unit

22 144 tests  ±0   20 407 ✅ ±0   6m 32s ⏱️ +9s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c8f7914. ± Comparison against base commit 31209be.

♻️ This comment has been updated with latest results.

[github-actions]

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   21m 32s ⏱️ - 1h 23m 29s
555 tests  - 4 076  330 ✅  - 3 861  225 💤  - 215  0 ❌ ±0 
557 runs   - 4 076  330 ✅  - 3 861  227 💤  - 215  0 ❌ ±0 

Results for commit c8f7914. ± Comparison against base commit 31209be.

This pull request removes 4076 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c8f7914. ± Comparison against base commit 31209be.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   33m 33s ⏱️
579 tests 355 ✅ 224 💤 0 ❌
585 runs  355 ✅ 230 💤 0 ❌

Results for commit c8f7914.

♻️ This comment has been updated with latest results.

[pinzon]

👍

[bentsku]

Just a comment: this looks like it was not squashed merged but rebased merged:

[simonrw]

Ah yes thanks @bentsku I guess GH considers the setting global? I had rebase merged some other PRs recently

[bentsku]

Yeah, I guess it remembers the last value used, not super clear 😅