Skip to content

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 21, 2025

Motivation

While looking at the some exception reports, I've spotted the following:

exception while calling apigateway.DeleteIntegrationResponse: 'NoneType' object has no attribute 'to_json'

Looking at the code, it seemed there was almost no validation, and the code would do a value.get(x, None).to_json() which would fail.

We can internalize the DeleteIntegrationResponse and add a bit of validation

Changes

  • add test around validation of DeleteIntegrationResponse
  • implement DeleteIntegrationResponse in our provider
  • moved code around to group handler that are about the same resource

@bentsku bentsku self-assigned this Aug 21, 2025
@bentsku bentsku added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Aug 21, 2025
@bentsku bentsku added this to the 4.8 milestone Aug 21, 2025
Copy link

Test Results - Preflight, Unit

22 144 tests  ±0   20 407 ✅ ±0   6m 23s ⏱️ +4s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit e96184f. ± Comparison against base commit a7937e8.

Copy link

LocalStack Community integration with Pro

    2 files      2 suites   17m 55s ⏱️
1 160 tests 1 092 ✅ 68 💤 0 ❌
1 162 runs  1 092 ✅ 70 💤 0 ❌

Results for commit e96184f.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit e96184f. ± Comparison against base commit a7937e8.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   37m 7s ⏱️
1 184 tests 1 117 ✅ 67 💤 0 ❌
1 190 runs  1 117 ✅ 73 💤 0 ❌

Results for commit e96184f.

@bentsku bentsku marked this pull request as ready for review August 21, 2025 18:27
@bentsku bentsku requested a review from cloutierMat as a code owner August 21, 2025 18:27
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bentsku bentsku merged commit ac189fe into main Aug 21, 2025
47 of 51 checks passed
@bentsku bentsku deleted the fix-apigw-report branch August 21, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs: skip Pull request does not require documentation changes semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants