Skip to content

Conversation

bblommers
Copy link
Contributor

Motivation

If an image specifies a VOLUME ["/tmp"] command, this results in the creation of an anonymous volume.

When you delete a container, this volume is not deleted automatically - this has be explicitly configured via docker container rm --volumes

This PR adds support for that argument, plus a test to verify that an anonymous volume is created and deleted after using this argument.

@bblommers bblommers added this to the 4.8 milestone Aug 29, 2025
@bblommers bblommers added area: docker Use Docker with LocalStack semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Aug 29, 2025
@bblommers bblommers marked this pull request as draft August 29, 2025 10:03
Copy link

Test Results - Preflight, Unit

22 158 tests  ±0   20 421 ✅ ±0   6m 30s ⏱️ +3s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c58e0df. ± Comparison against base commit 38aecc7.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ -8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c58e0df. ± Comparison against base commit 38aecc7.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 21m 8s ⏱️ -24s
5 005 tests +2  4 403 ✅ +1  602 💤 +1  0 ❌ ±0 
5 011 runs  +2  4 403 ✅ +1  608 💤 +1  0 ❌ ±0 

Results for commit c58e0df. ± Comparison against base commit 38aecc7.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 37s ⏱️ +7s
4 632 tests ±0  4 189 ✅ ±0  443 💤 ±0  0 ❌ ±0 
4 634 runs  ±0  4 189 ✅ ±0  445 💤 ±0  0 ❌ ±0 

Results for commit c58e0df. ± Comparison against base commit 38aecc7.

@bblommers bblommers marked this pull request as ready for review August 29, 2025 11:01
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, makes sense!

@bblommers bblommers merged commit c7c025f into main Sep 4, 2025
47 of 50 checks passed
@bblommers bblommers deleted the docker-delete-anon-volumes branch September 4, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docker Use Docker with LocalStack docs: skip Pull request does not require documentation changes semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants