Skip to content

Conversation

kakakakakku
Copy link
Contributor

Hi😀 Thanks for the useful tools.

I noticed that the README.md described the CONFIG_STRATEGY as separate, but in the actual implementation only separation works.

$ python bin/pulumilocal version
Config strategy: None
Config strategy is not recognised. Falling back to default ("overwrite").
v3.193.0

$ export CONFIG_STRATEGY=overwrite         
$ python bin/pulumilocal version  
v3.193.0

$ export CONFIG_STRATEGY=override 
$ python bin/pulumilocal version 
v3.193.0

$ export CONFIG_STRATEGY=separate
$ python bin/pulumilocal version        
Config strategy: separate
Config strategy is not recognised. Falling back to default ("overwrite").
v3.193.0

$ export CONFIG_STRATEGY=separation        
$ python bin/pulumilocal version          
v3.193.0

Check

I also ran the test tests/test_apply.py::test_config_strategy, and all cases passed successfully.

The separate case is still included in the tests, but from the behavior it seems to be used as an example of falling back to the default (overwrite) strategy when the value is not recognized.

$ pytest -v tests/test_apply.py::test_config_strategy
======================================================= test session starts ========================================================
collected 5 items                                                                                                                  

tests/test_apply.py::test_config_strategy[override] PASSED                                                                                                                               [ 20%]
tests/test_apply.py::test_config_strategy[overwrite] PASSED                                                                                                                              [ 40%]
tests/test_apply.py::test_config_strategy[separation] PASSED                                                                                                                             [ 60%]
tests/test_apply.py::test_config_strategy[separate] PASSED                                                                                                                               [ 80%]
tests/test_apply.py::test_config_strategy[] PASSED                                                                                                                                       [100%]

================================================================================ 5 passed in 124.64s (0:02:04) =================================================================================

Thank you😀

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks a lot for the proactive contribution! 💯

@alexrashed alexrashed merged commit 946bb9e into localstack:main Sep 9, 2025
1 check passed
@kakakakakku kakakakakku deleted the separate branch September 9, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants