Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rasters write support to HDFS / S3 #2102

Merged

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Mar 27, 2017

Hadoop based PNG / JPG / GeoTiff images write. Fixes #2080

  • tests

@pomadchin pomadchin changed the title Rasters write support to HDFS / S3 [WIP] Rasters write support to HDFS / S3 Mar 27, 2017
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@pomadchin pomadchin force-pushed the feature/generic-raster-writers branch from cde2e71 to a77e695 Compare March 27, 2017 13:16
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@pomadchin pomadchin force-pushed the feature/generic-raster-writers branch from b007766 to da40aa3 Compare March 28, 2017 10:10
@pomadchin pomadchin changed the title [WIP] Rasters write support to HDFS / S3 Rasters write support to HDFS / S3 Mar 28, 2017
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@pomadchin pomadchin force-pushed the feature/generic-raster-writers branch from da40aa3 to 68b7eb0 Compare March 28, 2017 10:16
@lossyrob lossyrob self-requested a review March 29, 2017 17:02
@pomadchin pomadchin added this to the 1.1 milestone Mar 30, 2017
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@pomadchin pomadchin force-pushed the feature/generic-raster-writers branch from 0d7ead8 to da84e38 Compare March 31, 2017 05:35
@@ -59,7 +59,8 @@ package object spark
with stitch.Implicits
with summary.Implicits
with summary.polygonal.Implicits
with tiling.Implicits {
with tiling.Implicits
with spark.raster.io.Implicits {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the pattern. This should be on the import geotrellis.spark.io._ package.

import org.apache.hadoop.fs.Path
import org.apache.spark.SparkContext

object GeoTiffHadoopReader {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in hadoop subproject

Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@pomadchin pomadchin force-pushed the feature/generic-raster-writers branch from e0eef5d to db86ac5 Compare March 31, 2017 18:08
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@pomadchin pomadchin force-pushed the feature/generic-raster-writers branch from c7547ff to cf14df3 Compare April 3, 2017 14:34
@echeipesh
Copy link
Contributor

This looks good and comment from @lossyrob are addressed.

@lossyrob lossyrob merged commit 490c6c2 into locationtech:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants