-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CoverageSimplifier #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was an error where only one tolerance was considered for each coverage edge
|
||
setCoordinates(edges, linesSimp); | ||
int index1 = covEdge.getAdjacentIndex(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int index1 = covEdge.getAdjacentIndex(1);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Need a unit test to verify that.
I have a suggestion here. Take the geometry from example testInnerHoleTouchingShell. If the tolerances 0,500,500 are provided then the holes are not simplified. I think it should be possible to coarsen hole or island polygons since they do not have any significant overlap with the exterior ring of the geometry enclosing them. Therefore we should probably skip the tolerance comparisson in such a case. A flag could be passed (e.g. forceHoleTolerances) to make this optional. |
Improves
CoverageSimplier
: