Improve GeometryPrecisionReducer to handle GeometryCollections, produce valid result #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
dr-jts
force-pushed
the
fix-geomprecisionreducer
branch
from
67b3df8
to
7e8a7d1
Compare
dr-jts
changed the title
|
Fixes #88 |
|
Fixes #324 |
This was referenced Dec 14, 2020
|
Why is this listed as an API change in te release notes? |
Correct, the actual API hasn't changed. But the behaviour of |
strk
pushed a commit
to libgeos/geos
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve GeometryPrecisionReducer to handle GeometryCollections.
This also fixes the issue where some valid inputs could produce an invalid result (seee #8, #324).
However, it does make GeometryPrecisionReducer less tolerant of invalid input. There may be cases where invalid input "worked" previously and now produces an
IllegalArgumentException. (see #653).Signed-off-by: Martin Davis mtnclimb@gmail.com