Fix RelateOp for empty geometry and closed linear geometry #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geometry Signed-off-by: Martin Davis <mtnclimb@gmail.com>
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Sep 13, 2022
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Sep 13, 2022
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Sep 14, 2022
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
dbaston
added a commit
to libgeos/geos
that referenced
this pull request
Sep 14, 2022
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
dbaston
added a commit
to libgeos/geos
that referenced
this pull request
Sep 19, 2022
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
dbaston
added a commit
to libgeos/geos
that referenced
this pull request
Sep 19, 2022
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing bug in
relatewhich did not compute the correct DE-9IM dimension entry for Exterior-Boundaryfor the case of an empty geometry and a closed linear geometry.
The original code defaulted the value of EB entry to
0. The correct algorithm needs to determine the entry based on whether the linear geometry has a non-empty boundary. In the case of closed linear geometries, the boundary is empty, and the EB entry isF. The boundary also depends on the Boundary Node Rule being used - all cases are now handled.See GISSE 384789 for original report of this issue.
Signed-off-by: Martin Davis mtnclimb@gmail.com