Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IsSimpleOp design and performance #717

Merged
merged 1 commit into from
May 17, 2021
Merged

Improve IsSimpleOp design and performance #717

merged 1 commit into from
May 17, 2021

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented May 14, 2021

Improves design and performance of IsSimpleOp.

  • moves code to org.locationtech.jts.operation.valid package
  • removes dependency on GeometryGraph
  • uses simpler and faster spatial index scan technique
  • allows operation to short-circuit terminate as soon as a non-simple intersection is found
  • adds ability to return all non-simple intersections

Also fixes #716.

Signed-off-by: Martin Davis mtnclimb@gmail.com

@dr-jts
Improve IsSimpleOp
e591ed2 
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
@dr-jts dr-jts self-assigned this May 14, 2021
@dr-jts dr-jts merged commit fd65e7b into locationtech:master May 17, 2021
@dr-jts dr-jts deleted the improve-issimpleop branch May 17, 2021 17:34
pramsey added a commit to pramsey/geos that referenced this pull request Jun 8, 2021
@pramsey
Port locationtech/jts#717 Improve IsSimpleOp design and performance
7136961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dr-jts dr-jts

Labels
jts-core type-bug type-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsSimple incorrectly reports duplicate line elements as simple
1 participant
@dr-jts