Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Improve IsValidOp #748

Merged
merged 7 commits into from
Jun 25, 2021
Merged

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Jun 25, 2021

This is an improvement to PR #743 that also fixes some bugs.

  • fixes the categorization of types of invalidity.
  • fixes a bug that caused polygons with multiple holes touching at the same point to be reported as invalid
  • improves code understandability

Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
@dr-jts dr-jts self-assigned this Jun 25, 2021
@dr-jts dr-jts merged commit fe1fe57 into locationtech:master Jun 25, 2021
@dr-jts dr-jts deleted the improve-isvalidop branch June 25, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant