Fix DiscreteFrechetDistance Bresenham algorithm #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FObermaier Can you review this fix for #764 ? |
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
dr-jts
force-pushed
the
fix-frechetdist-bresenham
branch
from
4cedb6b
to
f067c9a
Compare
FObermaier
approved these changes
Oct 14, 2021
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
DiscreteFrechetDistanceBresenham algorithm for matrix diagonals which caused anArrayIndexOutOfBoundsExceptionwhen one geometry had more than twice the vertices of the other one.It also simplifies the code to reflect the limited requirement of computing the diagonal of a matrix, rather than a general line.
Also included are Javadoc improvements, some renaming, and moving performance test classes into
test.perf.algorithm.distance.Signed-off-by: Martin Davis mtnclimb@gmail.com