Allow specifying a fixed PrecisionModel via grid size #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows specifying a fixed
PrecisionModelvia the grid size, instead of the scale factor. This is done by providing a negative value to thePrecisionModelconstructor.This is used to specify precise integral grid sizes, and provides a more accurate and robust rounding. Otherwise an integral grid size must be specified by the reciprocal scale factor, which in most cases cannot be computed exactly, and hence causes undesirable decimal places in computed precise values.
Internally the scale factor is computed as the reciprocal of the (positive) grid size value.
Signed-off-by: Martin Davis mtnclimb@gmail.com