Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the buffer generated for Mitred Joins #818

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Dec 14, 2021

Fixes the buffer generated for mitred joins.

Previously the buffer generated did not correctly maintain the buffer distance with mitred joins (see libgeos/geos#531).

Example 1

LINESTRING (20 50, 20 80, 50 80)
  • Buffer distance = 10, Flat Cap, Mitre Limit = 2
    image
  • Buffer distance = 10, Flat Cap, Mitre Limit = 1
    image
  • Buffer distance = 10, Flat Cap, Mitre Limit = 0
    image

Example 2

LINESTRING (10 80, 70 50, 10 50)
  • Buffer distance = 10, Flat Cap, Mitre Limit = 5
    image
  • Buffer distance = 10, Flat Cap, Mitre Limit = 5
    image

Signed-off-by: Martin Davis mtnclimb@gmail.com

Signed-off-by: Martin Davis <mtnclimb@gmail.com>
@dr-jts dr-jts merged commit 9442116 into locationtech:master Dec 14, 2021
@dr-jts dr-jts deleted the fix-buffer-mitrejoin branch December 14, 2021 22:50
pramsey added a commit to pramsey/geos that referenced this pull request Jan 10, 2022
pramsey added a commit to libgeos/geos that referenced this pull request Jan 10, 2022
Fix the buffer generated for Mitred Joins
@jodygarnett jodygarnett added this to the 1.19.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants