Skip to content

optimize line string #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

optimize line string #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/main/java/org/locationtech/spatial4j/shape/jts/JtsGeometry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.vividsolutions.jts.geom.*;
import com.vividsolutions.jts.geom.prep.PreparedGeometry;
import com.vividsolutions.jts.geom.prep.PreparedGeometryFactory;
import com.vividsolutions.jts.geom.prep.PreparedLineString;
import com.vividsolutions.jts.operation.union.UnaryUnionOp;
import com.vividsolutions.jts.operation.valid.IsValidOp;

Expand Down Expand Up @@ -234,8 +235,16 @@ public SpatialRelation relate(Rectangle rectangle) {
SpatialRelation bboxR = bbox.relate(rectangle);
if (bboxR == SpatialRelation.WITHIN || bboxR == SpatialRelation.DISJOINT)
return bboxR;
// FYI, the right answer could still be DISJOINT or WITHIN, but we don't know yet.
return relate(ctx.getGeometryFrom(rectangle));

// FYI, the right answer could still be DISJOINT, but cannot be WITHIN.

Geometry rectangleGeom = ctx.getGeometryFrom(rectangle);
if (!rectangle.isEmpty() && preparedGeometry instanceof PreparedLineString) {
// We know linestring cannot contain a rectangle so we just need to check for intersects.
return preparedGeometry.intersects(rectangleGeom) ? SpatialRelation.INTERSECTS : SpatialRelation.DISJOINT;
}

return relate(rectangleGeom);
}

public SpatialRelation relate(final Circle circle) {
Expand Down