tokio: Fix the way of using oneshot::Sender #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to docs of tokio::sync::oneshot::Sender.send, that method "attempts to send a value on this channel, returning it back if it could not be sent." Err case of send() is just simply returning the sent value back. Quite confusing, I was expecting some real error there. But well, according to the example snippet: https://docs.rs/tokio/1.16.1/tokio/sync/oneshot/struct.Sender.html#examples-1 we are just logging a custom error there. Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
mjura
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
LGTM, it is partially fixing #169
error:
mjura@gecko:~/git/lockc> kubectl logs -n lockc lockcd-dn7kf -f
2022-02-09T14:08:17.937616Z ERROR lockcd: could not send eBPF command result although the operation was succeessful command="add_proceess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs of tokio::sync::oneshot::Sender.send, that method
"attempts to send a value on this channel, returning it back if it could
not be sent."
Err case of send() is just simply returning the sent value back. Quite
confusing, I was expecting some real error there. But well, according to
the example snippet:
https://docs.rs/tokio/1.16.1/tokio/sync/oneshot/struct.Sender.html#examples-1
we are just logging a custom error there.
Signed-off-by: Michal Rostecki mrostecki@opensuse.org