Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrestrict version strings #27

Closed
wants to merge 3 commits into from
Closed

Unrestrict version strings #27

wants to merge 3 commits into from

Conversation

the-mikedavis
Copy link

Closes #26.

@paulbovbel
Copy link
Contributor

I can see the motivation for this PR, however semantically, backports.weakref==1.0.post1 is 'newer' than backports.weakref==1.0, which I think fails the test here.

I'm considering just dropping the fancy version munging period, and going for a 'top-most version declaration wins' approach when combining requirements, and just use the package name as a key. I believe this is basically how pip works anyways, since it doesn't do any real dependency resolution (pypa/pip#988), and it's probably delusional to do a half-baked implementation here.

Version munging in catkin_virtualenv has so-far caused nothing but problems (#12, #18)

@ablakey proposed looking at pipenv which is supposedly smarter than this, so maybe a catkin_pipenv re-implementation can solve these problems in the future.

@paulbovbel paulbovbel mentioned this pull request Dec 3, 2018
Merged
@paulbovbel paulbovbel closed this Dec 4, 2018
@the-mikedavis the-mikedavis deleted the unrestrict-version-strings branch December 4, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-mikedavis @paulbovbel