Fix trailing edge issue in throttle

[cpnota]

PR to address issue #3051

Note: Given the state of flux of the repo, I was unable to run any scripts or tests, except for some local tests. There are also not any tests here, since they don't seem to be in this repo? Please advise.

Eventually I determined that the issue boils down to a fundamental incompatibility between the expectations for debounce and the expectations for throttle. Following the trailing edge, debounce does not (and should not) care about the the amount of time elapsed before the next leading edge. throttle does. There seem to be three possible approaches to resolving this:

1. Decouple the throttle and debounce implementations again. No thanks.
2. Reclaim maxWait in the name of House Throttle. In the original debounce-based throttle implementation, setting maxWait reset the lastCall time to the time that the trailing edge created by maxWait was invoked (see here. This is ostensibly not correct, which is probably why the behavior was changed at some point.
3. Add a new option that throttle can utilize. This is the approach I went with.

I added an option called cooldown which lets you specify the minimum amount of time that must elapse between a trailing edge and a leading edge. Calls to debounced that occur in that interval are deferred until the end of that cooldown period (effectively creating a new trailing edge).

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

[cpnota]

btw I signed the CLA, but the check hasn't updated. @jsf-clabot ?

[jdalton]

@cpnota The CLA should be signed with the name and email associated with your git config. You can update your git config info then git commit --amend --reset-author on your commits and force push.

[jdalton]

Closing as abandoned by OP.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.