-
Notifications
You must be signed in to change notification settings - Fork 4
Expose a denormalization for selectors #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/test * 'master' of github.com:log-oscon/redux-wpapi: Document patching version Renames entity to resource in these file Release 1.0.0
* feature/test: Fix typos
* feature/test: Regressing version (the version was mistakenly changed) localID -> resourceLocalID (conformant with adapter signature)
xipasduarte
reviewed
Sep 19, 2016
CHANGELOG.md
Outdated
|
||
## [new release] | ||
|
||
* Expose a denormalization mechanism so consumer can transform local ids into resources denormalized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the PR reference and link
* feature/test: Fix alignments, adds CHANGELOG PR reference
xipasduarte
approved these changes
Sep 19, 2016
RicCastelhano
approved these changes
Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
withDenormalize
which provides a denormalization function into a consumer selector, bound to the current store state, through a thunk. This way it can turn alocalResourceID
into a denormalized resource. It's useful so another reducer can refer only bylocalResourceID
s and denormalize it in render time.Plus, now consumers can access the resource local id by using the
id
symbol.