no-unused-vars is configured to ignore args
#26
Labels
Comments
mdeltito
added a commit
that referenced
this issue
Dec 5, 2022
Previously we allowed unused arguments entirely, which can be a footgun (particularly in Tap tests with `t`). This enforces the `no-unused-vars` rule for arguments too, allowing unused arguments as long as later args _are_ used. Closes: #26
mdeltito
added a commit
that referenced
this issue
Dec 5, 2022
Previously we allowed unused arguments entirely, which can be a footgun (particularly in Tap tests with `t`). This enforces the `no-unused-vars` rule for arguments too, allowing unused arguments as long as later args _are_ used. BREAKING CHANGES: all named arguments and all positional arguments _after the last used argument_ will now be checked. Closes: #26
mdeltito
added a commit
that referenced
this issue
Dec 6, 2022
Previously we allowed unused arguments entirely, which can be a footgun (particularly in Tap tests with `t`). This enforces the `no-unused-vars` rule for arguments too, allowing unused arguments as long as later args _are_ used. BREAKING CHANGES: all named arguments and all positional arguments _after the last used argument_ will now be checked. Closes: #26
|
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a footgun, and the current setup is likely a holdover from the early stages of introducing this configuration org-wide. We should fix this and enforce
after-used.The text was updated successfully, but these errors were encountered: