fix: don't duplicate on tailer restart #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhokhlov
reviewed
Apr 17, 2023
jakedipity
force-pushed
the
jakedipity/dupe-on-restart
branch
from
1c1fe3b
to
846e122
Compare
jakedipity
force-pushed
the
jakedipity/dupe-on-restart
branch
3 times, most recently
from
7792832
to
d1e559e
Compare
The agent reuses the same initial offsets created on agent startup each time the tailer is restarted. This causes the agent to send duplicate logs each time the tailer restarts. This PR fixes that issue by generating the offsets each time the tailer restarts. Ref: LOG-16194 Signed-off-by: Jacob Hull <jacob@planethull.com>
jakedipity
force-pushed
the
jakedipity/dupe-on-restart
branch
from
d1e559e
to
28f6c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent reuses the same initial offsets created on agent startup each time the tailer is restarted. This causes the agent to send duplicate logs each time the tailer restarts. This PR fixes that issue by generating the offsets each time the tailer restarts.
Ref: LOG-16194