Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hyper-rustls to native-tls #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SivakaviKavitha
Copy link

@SivakaviKavitha SivakaviKavitha commented Jun 19, 2023

To avoid the ring dependency updated hyper-rustls to native-tls

Fixes: #521

To avoid the ring dependency updated hyper-rustls to native-tls

Fixes: rustls/rustls#521

Signed-off-by: Kavitha Sivakavi <kavitha.sivakavi@ibm.com>
@dkhokhlov
Copy link
Contributor

@SivakaviKavitha
I tried to build your PR with

make test

and got error:

error: failed to select a version for the requirement `native-tls = "^0.23"` (locked to 0.23.2)
candidate versions found which didn't match: 0.2.11, 0.2.10, 0.2.9, ...

Do you see the same?

@SivakaviKavitha
Copy link
Author

Hi @dkhokhlov ,
yeah, i am also facing the same issue.

Could you please suggest us on how to proceed ?

@c-nixon
Copy link
Collaborator

c-nixon commented Jun 20, 2023

Native-tls and rustls have different and incompatible APIs. Unfortunately if you want to add native-tls as an alternative TLS implementation it will need to be added behind a feature.

The logdna-rust api client library will also need to be updated to have an additional native-tls feature implementation.

The agent's other dependencies will also need their TLS implementations switched based on the native-tls/rustls feature, otherwise the build will still try to pull in rustls.

There may also be additional complications in the build-image if we want to build static binaries with native tls as we may need to provide a built copy of openssl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Alternate cryptographic backends
3 participants