[v1.6.3]: Fix Memory Leak and Improvements #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 24, 2020 14:16
matt-march
reviewed
Mar 3, 2020
| interface.address.startsWith('10.') || | ||
| interface.address.startsWith('172.') || | ||
| interface.address.startsWith('192.168.')); | ||
| })[0]; |
There was a problem hiding this comment.
Does this mean we're changing from picking the last interface given to the first?
Also, we're not saving ipv6 addresses anymore?
There was a problem hiding this comment.
if you take a look at the current implementation here, you can see in the if condition we just check for the existence of ipv4 despite of taking all[ifaces[i]].ipv4 || all[ifaces[i]].ipv6 - we have always taken the ipv4 if possible.
There was a problem hiding this comment.
Ah, good call about ipv6. Saw that and then promptly forgot it.
matt-march
approved these changes
Mar 3, 2020
smusali
pushed a commit
that referenced
this pull request
Aug 21, 2020
smusali
pushed a commit
that referenced
this pull request
Aug 21, 2020
alfeng6
pushed a commit
that referenced
this pull request
Aug 21, 2020
This was referenced Jan 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
Pull Requestcontains lots of version dependency updates mainly because of the issues and warnings their older versions had.According to this issue,
inflighthad a memory leak issue and was being used byglobwhich is among our dependencies.I have also converted
mochatests tojestto make it easy to extend for our developers, replaced the usage ofmacaddresswith built-inosand also cleaned upGruntfile.jstoo.