improvement: Rework options validation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm36
force-pushed
the
dmadhok/LOG-6969
branch
2 times, most recently
from
a868943
to
d260fd9
Compare
dm36
requested review from
darinspivey,
jakedipity,
smusali,
zeldanut and
a team
jakedipity
reviewed
Sep 9, 2020
dm36
force-pushed
the
dmadhok/LOG-6969
branch
9 times, most recently
from
6c96aea
to
7a4d870
Compare
dm36
force-pushed
the
dmadhok/LOG-6969
branch
from
7a4d870
to
9cb7ee7
Compare
mdeltito
reviewed
Sep 18, 2020
jakedipity
requested changes
Sep 18, 2020
jakedipity
reviewed
Sep 18, 2020
dm36
force-pushed
the
dmadhok/LOG-6969
branch
from
9cb7ee7
to
5c8d48b
Compare
dm36
force-pushed
the
dmadhok/LOG-6969
branch
from
7ed9b85
to
a31b55b
Compare
mdeltito
reviewed
Sep 23, 2020
mdeltito
reviewed
Sep 23, 2020
dm36
force-pushed
the
dmadhok/LOG-6969
branch
3 times, most recently
from
c00d0ad
to
78de87d
Compare
dm36
force-pushed
the
dmadhok/LOG-6969
branch
from
78de87d
to
3c3f10e
Compare
ghost
reviewed
Sep 24, 2020
dm36
force-pushed
the
dmadhok/LOG-6969
branch
8 times, most recently
from
627b9f1
to
496c280
Compare
mdeltito
requested changes
Sep 25, 2020
dm36
force-pushed
the
dmadhok/LOG-6969
branch
from
496c280
to
0b37997
Compare
dm36
force-pushed
the
dmadhok/LOG-6969
branch
2 times, most recently
from
a56bf3b
to
ea0f327
Compare
Rework validation for MAC and IP addresses to use net. Also updates max length to 80, the hostname regex, the README and reworks error handling. Semver: Patch Ref: LOG-6969
dm36
force-pushed
the
dmadhok/LOG-6969
branch
from
ea0f327
to
9e98963
Compare
mdeltito
approved these changes
Sep 30, 2020
jakedipity
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvement: Rework options validation
Rework validation for MAC and IP addresses to use net. Also updates max length to 80, the hostname regex, the README and reworks error handling.
Semver: Patch
Ref: LOG-6969