Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec.interceptors and spec.sink params in ClusterLogConfig/LogConfig CRD #120

Open
ethfoo opened this issue Mar 24, 2022 · 1 comment
Assignees
Labels
area/discovery Discovery component enhancement New feature or request status/done

Comments

@ethfoo
Copy link
Collaborator

ethfoo commented Mar 24, 2022

logConfig example below:

apiVersion: loggie.io/v1beta1
kind: LogConfig
metadata:
  name: tomcat
  namespace: default
spec:
  selector:
    type: pod
    labelSelector:
      app: tomcat
  pipeline:
    sources: |
      - type: file
        name: common
        paths:
          - stdout
          - /usr/local/tomcat/logs/*.log
    sink: |
      type: dev
      printEvents: false
    interceptors: |
      - type: rateLimit
        qps: 90000

So we can add sink/interceptors in ClusterLogConfig/LogConfig directly.

note:

  • sink/interceptors in logConfig have higher priority than sinkRef/interceptorRef, so when there are sink and sinkRef both in the logConfig, only sink is validate.
@ethfoo
Copy link
Collaborator Author

ethfoo commented Mar 24, 2022

TODO:
release in v1.1.0

  • update kubernetes usage docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/discovery Discovery component enhancement New feature or request status/done
Projects
None yet
Development

No branches or pull requests

1 participant