Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade client go version to 0.22.2 and fix int type error #99

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

fengshunli
Copy link
Contributor

No description provided.

@ethfoo
Copy link
Collaborator

ethfoo commented Mar 15, 2022

some golangci-lint check failed:

level=error msg="Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: inconsistent vendoring in /home/runner/work/loggie/loggie:\n\tgolang.org/x/text@v0.3.7: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgolang.org/x/time@v0.0.0-20210723032227-1f47c861a[9](https://github.com/loggie-io/loggie/runs/5549710651?check_suite_focus=true#step:4:9)ac: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgoogle.golang.org/protobuf@v1.26.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/api@v0.22.2: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/apimachinery@v0.22.2: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/client-go@v0.22.2: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/code-generator@v0.22.2: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/xhit/go-str2duration/v2@v2.0.0: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\tgolang.org/x/time@v0.0.0-20191024005414-555d28b269f0: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\tgoogle.golang.org/protobuf@v1.26.0-rc.1: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\tk8s.io/api@v0.19.8: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\tk8s.io/apimachinery@v0.19.8: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\tk8s.io/client-go@v0.19.8: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\tk8s.io/code-generator@v0.19.8: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod\n\nrun 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory\n"

@fengshunli
Copy link
Contributor Author

you can delete the vendor directly and ignore it in the git file

@ethfoo
Copy link
Collaborator

ethfoo commented Mar 15, 2022

I will create annother PR and fix this static checking

@ethfoo ethfoo merged commit 2ec6da8 into loggie-io:main Mar 15, 2022
@ethfoo ethfoo added bug Something isn't working area/discovery Discovery component labels Mar 15, 2022
@ethfoo ethfoo self-assigned this Mar 15, 2022
@ethfoo
Copy link
Collaborator

ethfoo commented Mar 15, 2022

#101

mmaxiaolei pushed a commit that referenced this pull request Mar 15, 2022
* Chore: go mod tidy&vendor, fix the static check in PR #99

* Fix: run k8s update-codegen.sh

* Chore: add kubernetes/client to golangci-lint skip-dir, remove unconvert check
ethfoo added a commit that referenced this pull request Mar 24, 2022
* Chore: go mod tidy&vendor, fix the static check in PR #99

* Fix: run k8s update-codegen.sh

* Chore: add kubernetes/client to golangci-lint skip-dir, remove unconvert check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/discovery Discovery component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants