[FSTORE-1789] Data source docs #498
Conversation
Co-authored-by: Aleksey Veresov <AKVeresov@gmail.com>
Co-authored-by: Aleksey Veresov <AKVeresov@gmail.com>
|
|
||
| === "PySpark" | ||
| ```python | ||
| import hopsworks | ||
| # Connect to the Hopsworks feature store | ||
| project = hopsworks.login() | ||
| feature_store = project.get_feature_store() | ||
| # Retrieve storage connector | ||
| # Retrieve data source | ||
| connector = feature_store.get_storage_connector('connector_name') |
There was a problem hiding this comment.
I guess the example is outdated.
There was a problem hiding this comment.
We had a discussion and it was decided that api will remain unchanged for 4.3 and 4.4. in 4.5 we are updating it to be using data sources and deprecating storage connector (currently working on those changes).
There was a problem hiding this comment.
Maybe at least change "connector_name" to something else? Is it the name of the saved credentials or the DS itself?
There was a problem hiding this comment.
Maybe it makes sense to make them really bold, or white on color (like below), so that the numbers stick out a bit more. I have not noticed them at all at first. 😅
There was a problem hiding this comment.
Yeah i think all images are like this and i dont want to edit everything right now.
Co-authored-by: Aleksey Veresov <AKVeresov@gmail.com>
Co-authored-by: Aleksey Veresov <AKVeresov@gmail.com>
|
|
||
| === "PySpark" | ||
| ```python | ||
| import hopsworks | ||
| # Connect to the Hopsworks feature store | ||
| project = hopsworks.login() | ||
| feature_store = project.get_feature_store() | ||
| # Retrieve storage connector | ||
| # Retrieve data source | ||
| connector = feature_store.get_storage_connector('connector_name') |
There was a problem hiding this comment.
Maybe at least change "connector_name" to something else? Is it the name of the saved credentials or the DS itself?
Co-authored-by: Aleksey Veresov <AKVeresov@gmail.com>
No description provided.