Catch IOError in stop #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2017
suyograo
reviewed
Feb 9, 2017
| @@ -139,5 +139,8 @@ def stop | |||
| else | |||
| @client_socket.close | |||
| end | |||
| rescue IOError | |||
| # if socket with @mode == client was closed by the client, an other call to @client_socket.close | |||
If socket with @mode == client was closed by the client, an other call to @client_socket.close will raise an IOError. We catch this IOError, log a warning and let logstash stop without error.
breml
force-pushed
the
bugfix-ioerror-on-close
branch
from
b2249bc to
2761f4e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If socket with @mode == client was closed by the client, an other call
to @client_socket.close will raise an IOError. We catch this
IOError and let logstash stop without error.