Skip to content

Conversation

process0
Copy link
Contributor

Documentation said key and data_type are not required, however there are no default values for those variables. Therefore, they are required.

CLA signed.

Documentation said `key` and `data_type` are not required, however there are no default values for those variables.  Therefore, they are required.
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @boundless-thread!

@robbavey robbavey merged commit c19526f into logstash-plugins:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants