New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: types for lastSynced #58

Merged

ai merged 1 commit into logux:main from nichoth:main

Mar 11, 2024

Contributor

nichoth commented Mar 11, 2024

In baseNode, we call this.log.store.setLastSynced with { received: number }. But the types for this method require an argument like { received: number, sent: number }.

Should this use a different type, so that you do not have to pass in a sent property?


          FIX: types for lastSynced

7450e5e

ai merged commit fe67ec4 into logux:main

4 checks passed

Member

ai commented Mar 11, 2024

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet