Improved Voice Messages UI #365

metaphore · 2020-10-08T09:19:06Z

New visual design for message audio attachments.

Non-continues updates from waveform view seeking.

metaphore · 2020-10-12T07:54:29Z

That should be fine for testing now.
@nielsandriesse could you please check on the styling? I followed iOS "foreground" color, but for the "background" counterpart, I use a bit muted version of the same color. I reckon it looks a bit more balanced, please let me know what you think.

Brice-W · 2020-10-19T01:19:26Z

@metaphore I tested this PR, I found a few issues:

Bug when replying to your own voice message:
Send a voice message, then select it and write a reply, send it, and make another reply and send it: the app goes back to the conversations list UI automatically
API 23:
Send a message from an API > 23 to API 23: the voice message UI looks different.
Still on API 23: after receiving and sending a voice message, go back to the main UI, then reopen the conversation with the voice messages: the voice messages UI keep changing.
API 21 & 22: voice messages aren’t working (the issue is already present in production, so unrelated to this PR, but if it’s easy and quick to fix that’d be good to include that fix)

nielsandriesse · 2020-10-19T02:50:52Z

A few things:

• If I tap a voice message while it's still loading, the app crashes.
• Style-wise things are looking nice (the adjusted background color you used looks good to me), but there are still a few differences with respect to iOS:

https://jmp.sh/K36ywLW
https://jmp.sh/SjHFdwB

• Let's cache the volume samples in the database. I do this on iOS because parsing them out is a relatively expensive operations (especially for long voice messages).
• Also, if you could take a look at @Brice-W's comments above that'd be great :)

Attachment audio extras job. Job manager supports parcelable types now.

metaphore · 2020-10-26T00:47:18Z

@Brice-W Should be good to test now.

Bug when replying to your own voice message

I couldn't reproduce that. Maybe it was fixed in the process.

API 21 & 22: voice messages aren’t working

It works for me on 21, but not on 22. There's an issue with the media player we are using, it might be incompatible with some system configurations, but it doesn't look like an easy fix could solve that. I can look into that but in a separate task.

the voice message UI looks different

For the APIs < 23 there is no support to extract the required data from audio files, thus fake waveform data is displayed.
Also on my API 23 emulator, there's a missing data field during the audio parsing process (which should be present according to the docs), so it fails and generates fake data again.
For other APIs, it might have small variations but in general, should look the same. Please let me know if you find any other inconsistencies in that regard.

metaphore · 2020-10-26T01:04:42Z

@Brice-W I found a way to patch the issue related to API 23, now it should work as expected.

Brice-W · 2020-10-26T05:58:37Z

@metaphore I tested the 3 cases again

I can't reproduce it as well, so it was fixed somehow 👍
API 23 works well :)
voice messages now work on both API 21 and 22. The UI looks different than other UI (like it did earlier in 23), but as long as it is working that's fine.

I just saw something else on APIs 21 -> 23: the voice message duration isn't displayed on the right of the message

metaphore · 2020-10-26T06:04:35Z

Thanks @Brice-W

on APIs 21 -> 23: the voice message duration isn't displayed on the right of the message

Oh yeah, sorry, forgot to mention that. It's the same as

or the APIs < 23 there is no support to extract the required data from audio files

So I cannot read it along with the raw audio data and thus the duration is just left empty and not displayed.

…into audio-view-design-update # Conflicts: # src/org/thoughtcrime/securesms/database/helpers/SQLCipherOpenHelper.java

nielsandriesse · 2020-10-28T22:28:04Z

Merged through #370 (except for the last dev merge)

nielsandriesse · 2020-10-28T22:41:28Z

src/org/thoughtcrime/securesms/loki/views/MessageAudioView.kt

+        View.inflate(context, R.layout.message_audio_view, this)
+        container = findViewById(R.id.audio_widget_container)
+        controlToggle = findViewById(R.id.control_toggle)
+        playButton = findViewById(R.id.play)


Just for future reference, you don't need to do this in Kotlin :) . You can just reference the view directly without first doing findViewById(...), assigning it, etc.

This is also why we have the convention of using lower camel case for view IDs

That was done intentionally. Kotlin synthetics are no longer recommended practice by Google https://www.reddit.com/r/androiddev/comments/ala9p2/why_kotlinx_synthetic_is_no_longer_a_recommended/?utm_source=amp&utm_medium=&utm_content=post_num_comments

They slow down things a bit and View Binding seems like a good alternative https://developer.android.com/topic/libraries/view-binding

Oh okay then, what a Google move haha

New day, new library at Google :) once this thing is out of alpha it might become the default xml view markup replacement https://developer.android.com/jetpack/compose

metaphore added 10 commits October 2, 2020 13:32

Audio view ported to Kotlin.

fdaadcb

Use waveform seek bar for audio message view.

e07cb71

Audio parsing and RMS computation for waveform visualization.

692741f

Properly handle seek bar input events.

7a9e73f

Audio duration label.

6df3264

Non-continues updates from waveform view seeking.

Normalization and smooth functions moved to the extension file.

8cbb34f

Waveform change animation.

c7d8998

Decoded audio ported to Kotlin.

cb67bfa

Waveform seek bar loading animation.

066234a

Themed colors for waveform seek bar and general cleanup.

efbcd0b

metaphore added the dev-tested label Oct 12, 2020

metaphore added 2 commits October 12, 2020 19:01

Waveform fill color attribute for message audio view.

793e6bf

Restrict the waveform seek bar progress value to a 0..1 range.

091847b

metaphore added 8 commits October 20, 2020 18:58

Audio extra columns for attachment table.

674da88

Merge remote-tracking branch 'loki/dev' into audio-view-design-update

001a5a9

Fixed attachment table queries.

b6d8898

Attachment audio extras job. Job manager supports parcelable types now.

Minor cleanup.

04c1328

A quick fix.

aacbe02

Better input event handling for waveform seek bar.

018e328

Message audio view is no longer seekable when it's uploading.

6a93653

Use the build tools version matching compile SDK.

5974abe

Gracefully handle the missing duration field for decoded audio.

7d9f5a4

Merge branch 'dev' into audio-view-design-update

82c5df4

metaphore added 2 commits October 26, 2020 23:14

New design for audio view progress bar.

42b9468

Merge branch 'dev' of https://github.com/loki-project/session-android …

6b1ba7a

…into audio-view-design-update # Conflicts: # src/org/thoughtcrime/securesms/database/helpers/SQLCipherOpenHelper.java

nielsandriesse changed the title ~~Audio view design update~~ Improved Voice Messages UI Oct 28, 2020

nielsandriesse mentioned this pull request Oct 28, 2020

Improved Voice Messages UI #370

Merged

nielsandriesse closed this Oct 28, 2020

nielsandriesse reviewed Oct 28, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved Voice Messages UI #365

Improved Voice Messages UI #365

metaphore commented Oct 8, 2020

metaphore commented Oct 12, 2020 •

edited

Brice-W commented Oct 19, 2020

nielsandriesse commented Oct 19, 2020

metaphore commented Oct 26, 2020 •

edited

metaphore commented Oct 26, 2020

Brice-W commented Oct 26, 2020

metaphore commented Oct 26, 2020

nielsandriesse commented Oct 28, 2020

nielsandriesse Oct 28, 2020

nielsandriesse Oct 28, 2020

metaphore Oct 28, 2020 •

edited

nielsandriesse Oct 28, 2020

metaphore Oct 28, 2020

Improved Voice Messages UI #365

Improved Voice Messages UI #365

Conversation

metaphore commented Oct 8, 2020

metaphore commented Oct 12, 2020 • edited

Brice-W commented Oct 19, 2020

nielsandriesse commented Oct 19, 2020

metaphore commented Oct 26, 2020 • edited

metaphore commented Oct 26, 2020

Brice-W commented Oct 26, 2020

metaphore commented Oct 26, 2020

nielsandriesse commented Oct 28, 2020

nielsandriesse Oct 28, 2020

Choose a reason for hiding this comment

nielsandriesse Oct 28, 2020

Choose a reason for hiding this comment

metaphore Oct 28, 2020 • edited

Choose a reason for hiding this comment

nielsandriesse Oct 28, 2020

Choose a reason for hiding this comment

metaphore Oct 28, 2020

Choose a reason for hiding this comment

metaphore commented Oct 12, 2020 •

edited

metaphore commented Oct 26, 2020 •

edited

metaphore Oct 28, 2020 •

edited