Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for invoking Thing actions through UI-based rules #3

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Add support for invoking Thing actions through UI-based rules #3

merged 9 commits into from
Oct 1, 2024

Conversation

florian-h05
Copy link

@florian-h05 florian-h05 commented Sep 30, 2024 •
edited
Loading

@lolodomo Can you please merge this PR into your branch, so this ends up in openhab#4392?
Please use rebase merging so the commit history is kept.

@florian-h05 florian-h05 mentioned this pull request Sep 30, 2024
Merged
@florian-h05 florian-h05 marked this pull request as draft September 30, 2024 19:01
@florian-h05 florian-h05 marked this pull request as ready for review September 30, 2024 19:05
@florian-h05
Refactor mapping logic to utility classes
a3baf59 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Add support for running Thing actions from UI-based rules
e7122d7 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Add support for QuantityType & Minor refactorings
cbb1ca5 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Fix invoking Thing actions via API & Minor JavaDoc changes
62ff6f8 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Add JavaDoc comment to ActionInputsToConfigDescriptionParameters::map…
b766e90 
… to also update SerialisedInputsToActionInputs

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Add support for DecimalType & Catch NFE and DTPE
9415c54 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Sep 30, 2024
Closed
@florian-h05
Add log message for Thing actions that will be hidden in the UI
98ecc27 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@lolodomo
Copy link
Owner

Please restore my different comments from my method adjustTypForfMethodArguments

@florian-h05
Copy link
Author

What you you mean exactly?

The splitting into

instanceof Double
   switch ...
instanceof String
   switch ...

?

@lolodomo
Copy link
Owner

I was meaning the comments I added in code.

And yes, I also prefer my last way to handle the different cases, more easy to read and understand.

@florian-h05
Copy link
Author

And yes, I also prefer my last way to handle the different cases, more easy to read and understand.

Haha, for me its the opposite ... I like to have everything in one place. Should I restore/apply your style?

@florian-h05
Address review comment
c0ec065 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Author

@lolodomo I have restored your comments and your style, only change is to use the new switch statement syntax.

@florian-h05
Address review
0e642de 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Author

@lolodomo Good catches, I addressed your review!

@lolodomo lolodomo merged commit ce0c2ce into lolodomo:enriched_actions_api Oct 1, 2024
@lolodomo
Copy link
Owner

lolodomo commented Oct 1, 2024

Thank you

@florian-h05 florian-h05 deleted the thing-actions-ui branch October 1, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @lolodomo