Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backupbackingimage): cleanup backup backing image in the backupstore_cleanup function (backport #1988) #1990

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 19, 2024

ref: longhorn/longhorn#9041

The issue is caused by the backup backing image left over from the previous test.
We should clean up the backup backing image in the backupstore_cleanup function


This is an automatic backport of pull request #1988 done by Mergify.

…ore_cleanup function

ref: longhorn/longhorn 9041

Signed-off-by: Jack Lin <jack.lin@suse.com>
(cherry picked from commit 9a80542)

# Conflicts:
#	manager/integration/tests/test_system_backup_restore.py
@mergify mergify bot requested a review from a team as a code owner July 19, 2024 22:12
@mergify mergify bot added the conflicts label Jul 19, 2024
Copy link
Author

mergify bot commented Jul 19, 2024

Cherry-pick of 9a80542 has failed:

On branch mergify/bp/v1.6.x/pr-1988
Your branch is up to date with 'origin/v1.6.x'.

You are currently cherry-picking commit 9a80542c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   manager/integration/tests/backupstore.py
	modified:   manager/integration/tests/common.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   manager/integration/tests/test_system_backup_restore.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@roger-ryao
Copy link
Contributor

The related PR has not been merged to v1.6.x yet: https://github.com/longhorn/longhorn-manager/pull/2824/files. So, this backport needs to wait until it is completed.

Copy link

github-actions bot commented Sep 3, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Sep 3, 2024
@roger-ryao
Copy link
Contributor

Closing this PR due to longhorn/longhorn-manager#2824 (comment)

@roger-ryao roger-ryao closed this Sep 10, 2024
@mergify mergify bot deleted the mergify/bp/v1.6.x/pr-1988 branch September 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants