fix(repository): findById will reject on no result

findById will now reject when no result is found, instead of
returning null.

Author: Kevin Delisle

packages/repository/src/legacy-juggler-bridge.ts

@@ -136,6 +136,11 @@ export class DefaultCrudRepository<T extends Entity, ID>
     const model = await ensurePromise(
       this.modelClass.findById(id, filter, options),
     );
+    if (!model) {
+      return Promise.reject(
+        new Error(`no ${this.modelClass.name} found with id "${id}"`),
+      );
+    }
     return this.toEntity(model);
   }
 

packages/repository/test/unit/repository/legacy-juggler-bridge.ts

@@ -180,4 +180,15 @@ describe('DefaultCrudRepository', () => {
     const ok = await repo.exists(note1.id);
     expect(ok).to.be.true();
   });
+
+  it('throws if findById does not return a value', async () => {
+    const repo = new DefaultCrudRepository(Note, ds);
+    try {
+      await repo.findById(999999);
+    } catch (err) {
+      expect(err).to.match(/no Note was found with id/);
+      return;
+    }
+    throw new Error('No error was returned!');
+  });
 });