Skip to content

Commit 466f79b

Browse files
Agnes Linagnes512
Agnes Lin
authored and
agnes512
committed
fix(cli): fix typo in cli relation tests
1 parent ecfe050 commit 466f79b

File tree

4 files changed

+66
-44
lines changed

4 files changed

+66
-44
lines changed

‎packages/cli/snapshots/integration/generators/relation.belongs-to.integration.snapshots.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export * from './order-class-type-customer-class-type.controller';
233233
`;
234234

235235
exports[
236-
`lb4 relation generates model relation for existing property name Verifies if property name that already existed will be overwritten 1`
236+
`lb4 relation generates model relation for existing property name verifies that a preexisting property will be overwritten 1`
237237
] = `
238238
import {Entity, model, property, belongsTo} from '@loopback/repository';
239239
import {Customer} from './customer.model';

‎packages/cli/snapshots/integration/generators/relation.has-many.integration.snapshots.js

Lines changed: 63 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77

88
'use strict';
99

10-
exports[`lb4 relation HasMany checks generated source class repository answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order"} generates Customer repository file with different inputs 1`] = `
10+
exports[
11+
`lb4 relation HasMany checks generated source class repository answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order"} generates Customer repository file with different inputs 1`
12+
] = `
1113
import {DefaultCrudRepository, repository, HasManyRepositoryFactory} from '@loopback/repository';
1214
import {Customer, Order} from '../models';
1315
import {DbDataSource} from '../datasources';
@@ -29,8 +31,9 @@ export class CustomerRepository extends DefaultCrudRepository<
2931
3032
`;
3133

32-
33-
exports[`lb4 relation HasMany checks generated source class repository answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass"} generates CustomerClass repository file with different inputs 1`] = `
34+
exports[
35+
`lb4 relation HasMany checks generated source class repository answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass"} generates CustomerClass repository file with different inputs 1`
36+
] = `
3437
import {DefaultCrudRepository, repository, HasManyRepositoryFactory} from '@loopback/repository';
3538
import {CustomerClass, OrderClass} from '../models';
3639
import {MyDBDataSource} from '../datasources';
@@ -52,8 +55,9 @@ export class CustomerClassRepository extends DefaultCrudRepository<
5255
5356
`;
5457

55-
56-
exports[`lb4 relation HasMany checks generated source class repository answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType"} generates CustomerClassType repository file with different inputs 1`] = `
58+
exports[
59+
`lb4 relation HasMany checks generated source class repository answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType"} generates CustomerClassType repository file with different inputs 1`
60+
] = `
5761
import {DefaultCrudRepository, repository, HasManyRepositoryFactory} from '@loopback/repository';
5862
import {CustomerClassType, OrderClassType} from '../models';
5963
import {MyDBDataSource} from '../datasources';
@@ -75,8 +79,9 @@ export class CustomerClassTypeRepository extends DefaultCrudRepository<
7579
7680
`;
7781

78-
79-
exports[`lb4 relation HasMany checks if the controller file created answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order"} checks controller content with hasMany relation 1`] = `
82+
exports[
83+
`lb4 relation HasMany checks if the controller file created answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order"} checks controller content with hasMany relation 1`
84+
] = `
8085
import {
8186
Count,
8287
CountSchema,
@@ -190,8 +195,9 @@ export class CustomerOrderController {
190195
191196
`;
192197

193-
194-
exports[`lb4 relation HasMany checks if the controller file created answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass"} checks controller content with hasMany relation 1`] = `
198+
exports[
199+
`lb4 relation HasMany checks if the controller file created answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass"} checks controller content with hasMany relation 1`
200+
] = `
195201
import {
196202
Count,
197203
CountSchema,
@@ -305,8 +311,9 @@ export class CustomerClassOrderClassController {
305311
306312
`;
307313

308-
309-
exports[`lb4 relation HasMany checks if the controller file created answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType"} checks controller content with hasMany relation 1`] = `
314+
exports[
315+
`lb4 relation HasMany checks if the controller file created answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType"} checks controller content with hasMany relation 1`
316+
] = `
310317
import {
311318
Count,
312319
CountSchema,
@@ -420,8 +427,9 @@ export class CustomerClassTypeOrderClassTypeController {
420427
421428
`;
422429

423-
424-
exports[`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","foreignKeyName":"mykey"} add the keyTo to the source model 1`] = `
430+
exports[
431+
`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","foreignKeyName":"mykey"} add the keyTo to the source model 1`
432+
] = `
425433
import {Entity, model, property, hasMany} from '@loopback/repository';
426434
import {Order} from './order.model';
427435
@@ -449,8 +457,9 @@ export class Customer extends Entity {
449457
450458
`;
451459

452-
453-
exports[`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","foreignKeyName":"mykey"} add the keyTo to the source model 2`] = `
460+
exports[
461+
`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","foreignKeyName":"mykey"} add the keyTo to the source model 2`
462+
] = `
454463
import {Entity, model, property} from '@loopback/repository';
455464
456465
@model()
@@ -479,8 +488,9 @@ export class Order extends Entity {
479488
480489
`;
481490

482-
483-
exports[`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","foreignKeyName":"mykey"} add the keyTo to the source model 1`] = `
491+
exports[
492+
`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","foreignKeyName":"mykey"} add the keyTo to the source model 1`
493+
] = `
484494
import {Entity, model, property, hasMany} from '@loopback/repository';
485495
import {OrderClass} from './order-class.model';
486496
@@ -507,8 +517,9 @@ export class CustomerClass extends Entity {
507517
508518
`;
509519

510-
511-
exports[`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","foreignKeyName":"mykey"} add the keyTo to the source model 2`] = `
520+
exports[
521+
`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","foreignKeyName":"mykey"} add the keyTo to the source model 2`
522+
] = `
512523
import {Entity, model, property} from '@loopback/repository';
513524
514525
@model()
@@ -536,8 +547,9 @@ export class OrderClass extends Entity {
536547
537548
`;
538549

539-
540-
exports[`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","foreignKeyName":"mykey"} add the keyTo to the source model 1`] = `
550+
exports[
551+
`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","foreignKeyName":"mykey"} add the keyTo to the source model 1`
552+
] = `
541553
import {Entity, model, property, hasMany} from '@loopback/repository';
542554
import {OrderClassType} from './order-class-type.model';
543555
@@ -564,8 +576,9 @@ export class CustomerClassType extends Entity {
564576
565577
`;
566578

567-
568-
exports[`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","foreignKeyName":"mykey"} add the keyTo to the source model 2`] = `
579+
exports[
580+
`lb4 relation HasMany generates model relation with custom foreignKey answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","foreignKeyName":"mykey"} add the keyTo to the source model 2`
581+
] = `
569582
import {Entity, model, property} from '@loopback/repository';
570583
571584
@model()
@@ -593,8 +606,9 @@ export class OrderClassType extends Entity {
593606
594607
`;
595608

596-
597-
exports[`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","relationName":"myOrders"} relation name should be myOrders 1`] = `
609+
exports[
610+
`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","relationName":"myOrders"} relation name should be myOrders 1`
611+
] = `
598612
import {Entity, model, property, hasMany} from '@loopback/repository';
599613
import {Order} from './order.model';
600614
@@ -622,8 +636,9 @@ export class Customer extends Entity {
622636
623637
`;
624638

625-
626-
exports[`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","relationName":"myOrders"} relation name should be myOrders 2`] = `
639+
exports[
640+
`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order","relationName":"myOrders"} relation name should be myOrders 2`
641+
] = `
627642
import {Entity, model, property} from '@loopback/repository';
628643
629644
@model()
@@ -652,8 +667,9 @@ export class Order extends Entity {
652667
653668
`;
654669

655-
656-
exports[`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","relationName":"myOrders"} relation name should be myOrders 1`] = `
670+
exports[
671+
`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","relationName":"myOrders"} relation name should be myOrders 1`
672+
] = `
657673
import {Entity, model, property, hasMany} from '@loopback/repository';
658674
import {OrderClass} from './order-class.model';
659675
@@ -680,8 +696,9 @@ export class CustomerClass extends Entity {
680696
681697
`;
682698

683-
684-
exports[`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","relationName":"myOrders"} relation name should be myOrders 2`] = `
699+
exports[
700+
`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass","relationName":"myOrders"} relation name should be myOrders 2`
701+
] = `
685702
import {Entity, model, property} from '@loopback/repository';
686703
687704
@model()
@@ -709,8 +726,9 @@ export class OrderClass extends Entity {
709726
710727
`;
711728

712-
713-
exports[`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","relationName":"myOrders"} relation name should be myOrders 1`] = `
729+
exports[
730+
`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","relationName":"myOrders"} relation name should be myOrders 1`
731+
] = `
714732
import {Entity, model, property, hasMany} from '@loopback/repository';
715733
import {OrderClassType} from './order-class-type.model';
716734
@@ -737,8 +755,9 @@ export class CustomerClassType extends Entity {
737755
738756
`;
739757

740-
741-
exports[`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","relationName":"myOrders"} relation name should be myOrders 2`] = `
758+
exports[
759+
`lb4 relation HasMany generates model relation with custom relation name answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType","relationName":"myOrders"} relation name should be myOrders 2`
760+
] = `
742761
import {Entity, model, property} from '@loopback/repository';
743762
744763
@model()
@@ -766,8 +785,9 @@ export class OrderClassType extends Entity {
766785
767786
`;
768787

769-
770-
exports[`lb4 relation HasMany generates model relation with default values answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order"} has correct default imports 1`] = `
788+
exports[
789+
`lb4 relation HasMany generates model relation with default values answers {"relationType":"hasMany","sourceModel":"Customer","destinationModel":"Order"} has correct default imports 1`
790+
] = `
771791
import {Entity, model, property, hasMany} from '@loopback/repository';
772792
import {Order} from './order.model';
773793
@@ -795,8 +815,9 @@ export class Customer extends Entity {
795815
796816
`;
797817

798-
799-
exports[`lb4 relation HasMany generates model relation with default values answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass"} has correct default imports 1`] = `
818+
exports[
819+
`lb4 relation HasMany generates model relation with default values answers {"relationType":"hasMany","sourceModel":"CustomerClass","destinationModel":"OrderClass"} has correct default imports 1`
820+
] = `
800821
import {Entity, model, property, hasMany} from '@loopback/repository';
801822
import {OrderClass} from './order-class.model';
802823
@@ -823,8 +844,9 @@ export class CustomerClass extends Entity {
823844
824845
`;
825846

826-
827-
exports[`lb4 relation HasMany generates model relation with default values answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType"} has correct default imports 1`] = `
847+
exports[
848+
`lb4 relation HasMany generates model relation with default values answers {"relationType":"hasMany","sourceModel":"CustomerClassType","destinationModel":"OrderClassType"} has correct default imports 1`
849+
] = `
828850
import {Entity, model, property, hasMany} from '@loopback/repository';
829851
import {OrderClassType} from './order-class-type.model';
830852

‎packages/cli/test/integration/generators/relation.belongs-to.integration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ describe('lb4 relation', function() {
188188
},
189189
];
190190

191-
it('Verifies if property name that already existed will be overwritten ', async () => {
191+
it('verifies that a preexisting property will be overwritten', async () => {
192192
await sandbox.reset();
193193
await testUtils
194194
.executeGenerator(generator)

‎packages/cli/test/integration/generators/relation.has-many.integration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ describe('lb4 relation HasMany', function() {
307307
.withPrompts(multiItemPrompt);
308308
});
309309

310-
it('new controller file has benn created', async () => {
310+
it('new controller file has been created', async () => {
311311
const filePath = path.join(
312312
SANDBOX_PATH,
313313
CONTROLLER_PATH,

0 commit comments

Comments
 (0)