Skip to content

Commit 5494243

Browse files
committed
perf: update dockerfile to better version
Update Dockerfile to a better version that is slimmer and has no vulnerabilities detected by IBM Cloud
1 parent d4eb70c commit 5494243

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/cli/generators/app/templates/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
FROM node:10
1+
# Check out https://hub.docker.com/_/node to select a new base image
2+
FROM node:10-slim
23

34
# Set to a non-root built-in user `node`
45
USER node

packages/cli/test/integration/generators/app.integration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ describe('app-generator specific files', () => {
105105
});
106106

107107
it('generates docker files', () => {
108-
assert.fileContent('Dockerfile', /FROM node:10/);
108+
assert.fileContent('Dockerfile', /FROM node:10-slim/);
109109
assert.fileContent('.dockerignore', /node_modules/);
110110

111111
assert.fileContent('package.json', /"docker:build": "docker build/);

0 commit comments

Comments
 (0)