feat(context): add support for context.add(binding)

Author: raymondfeng

packages/context/src/context.ts

@@ -42,25 +42,33 @@ export class Context {
    * Create a binding with the given key in the context. If a locked binding
    * already exists with the same key, an error will be thrown.
    *
-   * @param key Binding key
+   * @param keyOrBinding Binding key or a binding
    */
   bind<ValueType = BoundValue>(
-    key: BindingAddress<ValueType>,
+    keyOrBinding: BindingAddress<ValueType> | Binding,
   ): Binding<ValueType> {
+    let key: string;
+    let binding: Binding<ValueType>;
+    if (keyOrBinding instanceof Binding) {
+      key = keyOrBinding.key;
+      binding = keyOrBinding;
+    } else {
+      key = keyOrBinding.toString();
+      binding = new Binding<ValueType>(key);
+    }
+
     /* istanbul ignore if */
     if (debug.enabled) {
       debug('Adding binding: %s', key);
     }
-    key = BindingKey.validate(key);
+
     const keyExists = this.registry.has(key);
     if (keyExists) {
       const existingBinding = this.registry.get(key);
       const bindingIsLocked = existingBinding && existingBinding.isLocked;
       if (bindingIsLocked)
         throw new Error(`Cannot rebind key "${key}" to a locked binding`);
     }
-
-    const binding = new Binding<ValueType>(key);
     this.registry.set(key, binding);
     return binding;
   }

packages/context/test/unit/context.unit.ts

@@ -71,6 +71,13 @@ describe('Context', () => {
       expect(result).to.be.true();
     });
 
+    it('accepts a binding', () => {
+      const binding = new Binding('foo').to('bar');
+      expect(ctx.bind(binding)).to.be.exactly(binding);
+      const result = ctx.contains('foo');
+      expect(result).to.be.true();
+    });
+
     it('returns a binding', () => {
       const binding = ctx.bind('foo');
       expect(binding).to.be.instanceOf(Binding);