Skip to content

Commit a50405a

Browse files
committed
fix: fix imports to use files owning the definitions
Importing from the root index leads to circular resolution and cause undefined artifacts. Since the root index re-export such artifacts, the compilation is good but it fails at runtime.
1 parent fd804a5 commit a50405a

File tree

11 files changed

+16
-12
lines changed

11 files changed

+16
-12
lines changed

packages/core/src/component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
// License text available at https://opensource.org/licenses/MIT
55

66
import {Constructor, Provider, BoundValue} from '@loopback/context';
7-
import {Server, Application, ControllerClass} from '.';
7+
import {Server} from './server';
8+
import {Application, ControllerClass} from './application';
89

910
/**
1011
* A map of name/class pairs for binding providers

packages/repository/src/connector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
Command,
1111
NamedParameters,
1212
PositionalParameters,
13-
} from '..';
13+
} from './common-types';
1414

1515
/**
1616
* Common properties/operations for connectors

packages/repository/src/decorators/metadata.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {InspectionOptions, MetadataInspector} from '@loopback/context';
2-
import {MODEL_PROPERTIES_KEY, MODEL_WITH_PROPERTIES_KEY} from '../';
3-
import {ModelDefinition, PropertyDefinition} from '../../index';
2+
import {MODEL_PROPERTIES_KEY, MODEL_WITH_PROPERTIES_KEY} from './model';
3+
import {ModelDefinition, PropertyDefinition} from '../model';
44
export class ModelMetadataHelper {
55
/**
66
* A utility function to simplify retrieving metadata from a target model and

packages/repository/src/legacy-juggler-bridge.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
Command,
2020
NamedParameters,
2121
PositionalParameters,
22-
} from '../index';
22+
} from './common-types';
2323

2424
type DataSourceType = juggler.DataSource;
2525
export {DataSourceType};

packages/repository/src/query.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {AnyObject} from '..';
1+
import {AnyObject} from './common-types';
22
import * as assert from 'assert';
33

44
// Copyright IBM Corp. 2017. All Rights Reserved.

packages/repository/src/types/model.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
// This file is licensed under the MIT License.
44
// License text available at https://opensource.org/licenses/MIT
55

6-
import {Model, Class} from '..';
6+
import {Class} from '../common-types';
7+
import {Model} from '../model';
78
import {ObjectType} from './object';
89

910
// tslint:disable:no-any

packages/repository/src/types/object.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// License text available at https://opensource.org/licenses/MIT
55

66
import * as util from 'util';
7-
import {Class, AnyObject} from '..';
7+
import {Class, AnyObject} from '../common-types';
88
import {Type} from './type';
99

1010
// tslint:disable:no-any

packages/rest/src/parser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// License text available at https://opensource.org/licenses/MIT
55

66
import {ServerRequest} from 'http';
7-
import {HttpErrors} from './';
7+
import * as HttpErrors from 'http-errors';
88
import {OperationObject, ParameterObject} from '@loopback/openapi-spec';
99
import {promisify} from '@loopback/core';
1010
import {

packages/rest/src/providers/log-error-provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// License text available at https://opensource.org/licenses/MIT
55

66
import {Provider} from '@loopback/context';
7-
import {ServerRequest} from '../';
7+
import {ServerRequest} from 'http';
88
import {LogError} from '../internal-types';
99

1010
export class LogErrorProvider implements Provider<LogError> {

packages/rest/src/rest-application.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {Application, ApplicationConfig, Server} from '@loopback/core';
2-
import {RestComponent, SequenceHandler, SequenceFunction} from './index';
2+
import {RestComponent} from './rest-component';
3+
import {SequenceHandler, SequenceFunction} from './sequence';
34
import {Binding, Constructor} from '@loopback/context';
45
import {format} from 'util';
56
import {RestBindings} from './keys';

0 commit comments

Comments
 (0)