Skip to content

Commit a701ce9

Browse files
author
Kevin Delisle
committed
feat(repository): Make property parameter optional
1 parent 80638b4 commit a701ce9

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

packages/repository/src/decorators/model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ export function model(definition?: ModelDefinitionSyntax) {
6767
* @param definition
6868
* @returns {(target:any, key:string)}
6969
*/
70-
export function property(definition: Partial<PropertyDefinition>) {
70+
export function property(definition?: Partial<PropertyDefinition>) {
7171
return PropertyDecoratorFactory.createDecorator(
7272
MODEL_PROPERTIES_KEY,
73-
definition,
73+
Object.assign({}, definition),
7474
);
7575
}

packages/repository/test/unit/decorator/model-and-relation.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ describe('model decorator', () => {
6767
@belongsTo({target: 'Customer'})
6868
// TypeScript does not allow me to reference Customer here
6969
customer: ICustomer;
70+
71+
// Validates that property no longer requires a parameter
72+
@property() isShipped: boolean;
7073
}
7174

7275
@model()
@@ -112,6 +115,7 @@ describe('model decorator', () => {
112115
},
113116
});
114117
expect(meta.id).to.eql({type: 'string', id: true, generated: true});
118+
expect(meta.isShipped).to.eql({type: Boolean});
115119
});
116120

117121
it('adds embedsOne metadata', () => {

0 commit comments

Comments
 (0)