fix: set foreignkey to be optional in the requestbody of hasmany relation

Author: Agnes Lin

packages/cli/generators/relation/has-many-relation.generator.js

@@ -51,6 +51,7 @@ module.exports = class HasManyRelationGenerator extends BaseRelationGenerator {
     this.artifactInfo.sourceModelPrimaryKeyType =
       options.sourceModelPrimaryKeyType;
     this.artifactInfo.targetModelPrimaryKey = options.targetModelPrimaryKey;
+    this.artifactInfo.foreignKeyName = options.foreignKeyName;
 
     const source = this.templatePath(CONTROLLER_TEMPLATE_PATH_HAS_MANY);
 

packages/cli/generators/relation/templates/controller-relation-template-has-many.ts.ejs

@@ -58,7 +58,10 @@ export class <%= controllerClassName %> {
     @requestBody({
       content: {
         'application/json': {
-          schema: getModelSchemaRef(<%= targetModelClassName %>, {exclude: ['<%= targetModelPrimaryKey %>']}),
+          schema: getModelSchemaRef(<%= targetModelClassName %>, {
+            exclude: ['<%= targetModelPrimaryKey %>'],
+            optional: ['<%= foreignKeyName %>']
+          }),
         },
       },
     }) <%= targetModelRequestBody %>: Omit<<%= targetModelClassName %>, '<%= targetModelPrimaryKey %>'>,

packages/cli/test/integration/generators/hasmany.relation.integration.js

@@ -439,7 +439,10 @@ context('check if the controller file created ', () => {
           /content: {'application\/json': {schema: getModelSchemaRef\(Order\)}},\n/,
           /},\n . {2}},\n .}\)\n {2}async create\(\n/,
           /\@param\.path\.number\('id'\) id: typeof Customer\.prototype\.id,\n/,
-          /\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(Order, {exclude: \['id'\]}\),\s+},\s+},\s+}\) order: Omit<Order, 'id'>,\n/,
+          /\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(Order, {\n/,
+          /exclude: \['id'\],\n/,
+          /optional: \['customerId'\]\n/,
+          /}\),\s+},\s+},\s+}\) order: Omit<Order, 'id'>,\n/,
           /\): Promise<Order> {\n/,
           /return this\.customerRepository\.orders\(id\)\.create\(order\);\n {2}}\n/,
         ];
@@ -449,7 +452,10 @@ context('check if the controller file created ', () => {
           /content: {'application\/json': {schema: getModelSchemaRef\(OrderClass\)}},\n/,
           /},\n . {2}},\n .}\)\n {2}async create\(\n/,
           /\@param\.path\.number\('id'\) id: typeof CustomerClass\.prototype\.custNumber,\n/,
-          /\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(OrderClass, {exclude: \['orderNumber'\]}\),\s+},\s+},\s+}\) orderClass: Omit<OrderClass, 'orderNumber'>,\n/,
+          /\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(OrderClass, {\n/,
+          /exclude: \['orderNumber'\],\n/,
+          /optional: \['customerClassCustNumber'\]\n/,
+          /}\),\s+},\s+},\s+}\) orderClass: Omit<OrderClass, 'orderNumber'>,\n/,
           /\): Promise<OrderClass> {\n/,
           /return this\.customerClassRepository\.orderClasses\(id\)\.create\(orderClass\);\n {2}}\n/,
         ];
@@ -459,7 +465,10 @@ context('check if the controller file created ', () => {
           /content: {'application\/json': {schema: getModelSchemaRef\(OrderClassType\)}},\n/,
           /},\n . {2}},\n .}\)\n {2}async create\(\n/,
           /\@param\.path\.number\('id'\) id: typeof CustomerClassType\.prototype\.custNumber,\n/,
-          /\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(OrderClassType, {exclude: \['orderString'\]}\),\s+},\s+},\s+}\) orderClassType: Omit<OrderClassType, 'orderString'>,\n/,
+          /\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(OrderClassType, {\n/,
+          /exclude: \['orderString'\],\n/,
+          /optional: \['customerClassTypeCustNumber'\]\n/,
+          /}\),\s+},\s+},\s+}\) orderClassType: Omit<OrderClassType, 'orderString'>,\n/,
           /\): Promise<OrderClassType> {\n/,
           /return this\.customerClassTypeRepository\.orderClassTypes\(id\)\.create\(orderClassType\);\n {2}}\n/,
         ];