fix(rest): make sure validation system error is reported

Author: raymondfeng

packages/rest/src/parser.ts

@@ -56,8 +56,7 @@ function getContentType(req: Request): string | undefined {
  * controller method
  *
  * @param request Incoming HTTP request
- * @param operationSpec Swagger spec defined in the controller
- * @param pathParams Path parameters in incoming HTTP request
+ * @param route Resolved Route
  */
 export async function parseOperationArgs(
   request: Request,

packages/rest/src/validation/request-body.validator.ts

@@ -93,13 +93,17 @@ function validateValueAgainstJsonSchema(
   const ajv = new AJV({
     allErrors: true,
   });
+
   try {
     if (ajv.validate(schemaWithRef, body)) {
       debug('Request body passed AJV validation.');
       return;
     }
   } catch (err) {
-    debug('Cannot execute AJV validation: %s', util.inspect(err));
+    debug('Fails to execute AJV validation:', err);
+    // TODO: [rfeng] Do we want to introduce a flag to disable validation
+    // or sink validation errors?
+    throw err;
   }
 
   debug('Invalid request body: %s', util.inspect(ajv.errors));

packages/rest/test/unit/request-body.validator.test.ts

@@ -43,6 +43,14 @@ const ADDRESS_SCHEMA = {
   },
 };
 
+const INVALID_ACCOUNT_SCHEMA = {
+  title: 'Account',
+  properties: {
+    title: {type: 'string'},
+    address: {$ref: '#/components/schemas/Invalid'},
+  },
+};
+
 describe('validateRequestBody', () => {
   it('accepts valid data omitting optional properties', () => {
     validateRequestBody({title: 'work'}, aBodySpec(TODO_SCHEMA));
@@ -113,6 +121,14 @@ describe('validateRequestBody', () => {
     );
   });
 
+  it('reports schema generation errors', () => {
+    expect(() =>
+      validateRequestBody({}, aBodySpec(INVALID_ACCOUNT_SCHEMA)),
+    ).to.throw(
+      "can't resolve reference #/components/schemas/Invalid from id #",
+    );
+  });
+
   it('resolves schema references', () => {
     const details: RestHttpErrors.ValidationErrorDetails[] = [
       {