Admin?

[joshuadavidthomas]

Any interest in adding admin integration for the models in this library? I've got a drop-in PR ready to go if so.

[kevinrenskers]

I was thinking about it, but notifications don’t seem like something people would manage themselves in the admin? Maybe just to view them while developing? 🤔

In my own project that uses this library I did add the admin config, but made everything read-only. But that doesn’t seem right as the “default” admin config either.

So I’m not 100% sure what to do here. What do you think? For which models would you include the admin config?

[joshuadavidthomas]

Yeah, I just used it as a CYA sanity check while I'm working on it in dev to check things were working how I expected. And I did the same thing with the readonly fields.

Unsure what others would expect, but having the notifications in the admin purely as a read only log doesn't bother me. Especially since I like the convenience of popping in to just check everything's running smoothly. But that could be just me getting a feel for the library and not really useful long-term? IDK 🤷

At the very least you could define the ModelAdmin classes and at the end of the file check settings.DEBUG and only call admin.register(...) then? Or define the default ModelAdmin classes and document how to register them and leave it up to the users whether they want to or not? But I guess at that point someone could just write their own (much like I did)... Maybe it's more trouble than it's worth.

[kevinrenskers]

I think if we add the admin model classes, then we should also just register them. The only thing is: if we make them read-only and someone wants to change that, they'd have to unregister the admin classes and create/register their own, which also kinda sucks. I also think it's probably more expected to have full-featured default admin model classes?

So basically, the admin.py from the example app could be moved to the library itself.

[joshuadavidthomas]

So basically, the admin.py from the example app could be moved to the library itself.

Ah! I somehow missed this. This would have been enough for me TBH. Maybe just document somewhere in the README as a first start?

[kevinrenskers]

That makes sense. I can always add the admin model classes later when more people ask.