-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1x ci #1015
0.1x ci #1015
Conversation
Our test suite changes in master were never backported to this branch. Removing linting from the circle ci config was easy enough, but now the tests don't run.
I think we have a couple options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to CircleCI, there are variant Docker images, tagged with lots of suffixes.
https://circleci.com/docs/2.0/circleci-images/#ruby
Perhaps the ones we use could try the 2.6-stretch
suffix, to make available lots of surrounding lsof etc?
Well, all of the image:
keys in this branch's CircleCI configuration would have to be updated.
|
||
ruby26: | ||
docker: | ||
- image: circleci/ruby:2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- image: circleci/ruby:2.6 | |
- image: circleci/ruby:2.6-stretch |
Closing in favor of just shipping v0.16.0 and a 0.16.x branch. |
@technoweenie do you wanna un-delete this branch? I can copy/paste these changes, but would rather just cherry-pick |
This PR sets up Circle CI, which we've already transitioned from. So I don't think it's makes sense to bring this back. |
Ah, I wasn't aware that the project was moving away from circleci |
Backports our current CircleCI/CodeClimate config over from master. Hopefully we can then test and merge #1013.