Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `Adapter#close` so that derived classes can call super. #1091

Merged
merged 3 commits into from Dec 27, 2019

Conversation

@ioquatix
Copy link
Contributor

ioquatix commented Dec 23, 2019

No description provided.

@ioquatix

This comment has been minimized.

Copy link
Contributor Author

ioquatix commented Dec 23, 2019

https://github.com/socketry/async-http-faraday/blob/master/lib/async/http/faraday/adapter.rb now supports this pretty well. It has both persistent connections, and concurrent requests.

@ioquatix ioquatix force-pushed the ioquatix:patch-2 branch from 5a417d9 to b419a8c Dec 23, 2019
@iMacTia

This comment has been minimized.

Copy link
Member

iMacTia commented Dec 27, 2019

Ignore the rubocop issues, I'm fixing them on master 👍

Copy link
Member

iMacTia left a comment

Logical continuation of #1069 👏

@iMacTia iMacTia merged commit 15595d0 into lostisland:master Dec 27, 2019
5 checks passed
5 checks passed
linting
Details
build (2.4.x)
Details
build (2.5.x)
Details
build (2.6.x) build (2.6.x)
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.