Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Adapter#close so that derived classes can call super. #1091

Merged
merged 3 commits into from
Dec 27, 2019
Merged

Add Adapter#close so that derived classes can call super. #1091

merged 3 commits into from
Dec 27, 2019

Conversation

ioquatix
Copy link
Contributor

No description provided.

@ioquatix
Copy link
Contributor Author

https://github.com/socketry/async-http-faraday/blob/master/lib/async/http/faraday/adapter.rb now supports this pretty well. It has both persistent connections, and concurrent requests.

@iMacTia
Copy link
Member

iMacTia commented Dec 27, 2019

Ignore the rubocop issues, I'm fixing them on master 👍

@iMacTia iMacTia mentioned this pull request Dec 27, 2019
Merged
iMacTia
iMacTia approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logical continuation of #1069 👏

@iMacTia iMacTia merged commit 15595d0 into lostisland:master Dec 27, 2019
@binarycode binarycode mentioned this pull request Feb 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioquatix @iMacTia