Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResponseMiddleware.define_parser unit test #190

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Add ResponseMiddleware.define_parser unit test #190

merged 1 commit into from
Aug 3, 2019

Conversation

olleolleolle
Copy link
Member

Here's a small unit test addition, to cover the comment in #189

@olleolleolle olleolleolle requested a review from iMacTia July 29, 2019 12:49
iMacTia
iMacTia approved these changes Aug 3, 2019
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for amending #189 and introducing the test coverage. It should have always been there!

@iMacTia iMacTia merged commit be68541 into master Aug 3, 2019
@iMacTia iMacTia deleted the amend-189 branch August 3, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olleolleolle @iMacTia