Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapped exception in Faraday::ParsingError to improve legibility of the error #255

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Apr 1, 2020

This is from that existing issue that's open, #160.

Fixes #160

@d-m-u d-m-u force-pushed the use_wrapped_exception_in_process_response branch from 368a4da to 6f5069f Compare April 1, 2020 13:21
@olleolleolle
Copy link
Member

The build fails with: bblimke/webmock#683

The resolution in there was: upgrade to 2.3.2. We run webmock-1.24.6.

@d-m-u d-m-u force-pushed the use_wrapped_exception_in_process_response branch from 39c3490 to 9189fb1 Compare April 1, 2020 15:53
@olleolleolle olleolleolle changed the title update the raise parsing error to use the wrapped exception Use wrapped exception in Faraday::ParsingError to improve legibility of the error Apr 1, 2020
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I support this change, and think we should use it.

@olleolleolle olleolleolle merged commit caff51d into lostisland:master Apr 1, 2020
@d-m-u d-m-u deleted the use_wrapped_exception_in_process_response branch April 1, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ParsingError as described in #144
2 participants